[PRD-609] fix: Broken file path #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultranvan
force-pushed
the
path-and-name-search
branch
3 times, most recently
from
365d2b9 to
23239b3
Compare
With #2612, we added the possibility to search on path + name by adding the name in the path, at indexing time. This is "heavy" from UX perspective, so let's remove it.
paultranvan
force-pushed
the
path-and-name-search
branch
from
23239b3 to
2e04419
Compare
Ldoppea
approved these changes
Nov 12, 2024
paultranvan
force-pushed
the
path-and-name-search
branch
from
b69c2cb to
c7a7ad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2612,
we added the possibility to search on path + name by adding the name in the path, at indexing time.
This breaks the possibility to open file because the path is not what is expected. So we remove the name from the path after search time.